ENH: Allow adjust=False when times is provided #59142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v3.0.0.rst
This change enables EWMA to be calculated recursively ("infinite history", i.e.
adjust=False
) for irregular-interval time series. Previouslynew_wt
was held constant in the ewm run loop, but nownew_wt
is updated each step through the series under the narrow condition thatadjust=False
andcom=1
.There may be a more elegant expression that will generalize to
com
values different than one, but using1 - old_wt
works nicely ifhalflife
is the only provided decay parameter since we are guaranteedcom=1
. The additional parameter restrictions to force this condition seem acceptable since there is already some restriction on decay parameters.FWIW I confirmed that results match polars and @azmyrajab's nice test function: